On 14 Jul 2022, at 19:51, Emma Finn wrote:
> From: Harry van Haaren <[email protected]>
>
> This commit adds the AVX512 implementation of the
> pop_vlan action.
>
> Signed-off-by: Emma Finn <[email protected]>
> ---
<SNIP>
> +#else /* __x86_64__ */
> +
> +#include <config.h>
+#include <errno.h>
> +#include "odp-execute-private.h"
> +/* Function itself is required to be called, even in e.g. 32-bit builds.
> + * This dummy init function ensures 32-bit builds succeed too.
> + */
> +
> +int
> +action_avx512_init(struct odp_execute_action_impl *self OVS_UNUSED)
> +{
> + return -ENOTSUP;
Changes look good to me, with the one problem reported by Ilya in the CI.
One tip from my side, before you send out a patch, make a copy of the GitHub
tree and push your changes. This will automatically run the CI.
This is a link for your patch I sent to my private GitHub fork:
https://github.com/chaudron/ovs/runs/7353230736?check_suite_focus=true
You can add my ACKed by, if you fix this.
//Eelco
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
