On 7/14/22 17:55, Frode Nordahl wrote: > * Update upstream OVS debian packaging to be on par with package > source in Debian/Ubuntu: > - Provide a openvswitch-switch-dpdk package that integrates with > the dpdk package in the distributions so that end users can opt > into a DPDK-enabled Open vSwitch binary. > - Provide systemd service files. > - Provide openvswitch-source package for reproducible integrated > build of for example OVN. > - Stop building shared library and subsequently remove > libopenvswitch and libopenvswitch-dev binary packages. > > Co-authored-by: Luca Boccassi <[email protected]> > Signed-off-by: Luca Boccassi <[email protected]> > Co-authored-by: Christian Ehrhardt <[email protected]> > Signed-off-by: Christian Ehrhardt <[email protected]> > Co-authored-by: James Page <[email protected]> > Signed-off-by: James Page <[email protected]> > Co-authored-by: Corey Bryant <[email protected]> > Signed-off-by: Corey Bryant <[email protected]> > Signed-off-by: Frode Nordahl <[email protected]> > ---
<snip> Hi, Frode. Just a last couple of questions about licenses. I see you removed the datapath/* section and it's fine, because we're going to remove that directory in the very next patch set anyway. But you also removed the build-aux/cccl licensing information. The main codebase is Apache 2, but build-aux/cccl is GPL-2, so I think we need to get the following section back: diff --git a/debian/copyright.in b/debian/copyright.in index bfc2b8c8b..64d23795d 100644 --- a/debian/copyright.in +++ b/debian/copyright.in @@ -85,6 +85,11 @@ Files: Copyright: (c) 2007-2017 Nicira, Inc. License: Apache-2.0-or-GPL-2.0 +Files: + build-aux/cccl +Copyright: (C) 2000-2003 Geoffrey Wossum <[email protected]> +License: GPL-2 + Files: lib/getopt_long.c include/windows/getopt.h datapath-windows/ovsext/Conntrack-tcp.c --- > +License: Sun-Industry-Standard-or-InMon-sFlow-License > + Retrieved from http://host-sflow.sourceforge.net/sissl.html, 2011-12-12: <snip SISS License> > + sFlow Specification, located at > http://sflow.org/developers/specifications.php The sFlow implementation is dual licensed and the name you gave to the license is 'Sun-Industry-Standard-or-InMon-sFlow-License', but you removed the text of the sFlow License from the patch. Was it intentional? I can bring it back like this: https://github.com/igsilya/ovs/commit/3ec73d20da35a156f0d6ab7e58a5e17ce56205af Does that make sense? If you agree, I'll add these changes to a patch before merging. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
