On 6/24/22 17:17, Eli Britstein wrote: > +Ori > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > *From:* Finn, Emma <[email protected]> > *Sent:* Friday, June 24, 2022 5:41 PM > *To:* Ilya Maximets <[email protected]>; [email protected] > <[email protected]>; Stokes, Ian <[email protected]> > *Cc:* Eli Britstein <[email protected]>; Slava Ovsiienko > <[email protected]>; Flavio Leitner <[email protected]>; Matan Azrad > <[email protected]> > *Subject:* RE: [ovs-dev] [PATCH] netdev-offload-dpdk: setting RSS hash types > in RSS action > > External email: Use caution opening links or attachments > > >> -----Original Message----- >> From: dev <[email protected]> On Behalf Of Ilya >> Maximets >> Sent: Monday 20 June 2022 19:00 >> To: [email protected]; Stokes, Ian <[email protected]> >> Cc: Eli Britstein <[email protected]>; [email protected]; Flavio Leitner >> <[email protected]>; [email protected]; [email protected] >> Subject: Re: [ovs-dev] [PATCH] netdev-offload-dpdk: setting RSS hash types >> in RSS action >> >> On 3/22/22 03:08, Harold Huang wrote: >> > Hello, >> > Is there any opinion from the OVS or DPDK MLX5 driver maintainers? >> > This is a serious issue we've found when we use MLX5 PMD driver to >> > offload OVS-DPDK. >> >> It looks like DPDK is very inconsistent and drivers do not really put any >> effort >> in setting up a "best effort" hashing mechanism. >> mlx5 driver seems to use just RTE_ETH_RSS_IP. >> >> I suppose, there is no harm in using the same set of hashing fields as we do >> for RSS configuration in netdev-dpdk. >> >> Ian, Eli, what do you think? >> > Hi, > > I took this patch and tested on both Intel E810 and i40e. Flows are being > offloaded correctly and this won't break MARK and RSS action for Intel NICs.
Thanks, Emma, Harold and Tonghao. Since there is no further progress on this topic and the patch seems to work fine, I applied it. Also backported down to 2.17 since this behavior may cause significant performance issues. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
