On Thu, Jul 21, 2022 at 3:44 PM Dumitru Ceara <[email protected]> wrote: > > On 7/21/22 03:14, [email protected] wrote: > > From: Numan Siddique <[email protected]> > > > > Compilation is failing with the error: > > > > File "Documentation/conf.py", line 61, in <module> > > with open(filename, 'rU') as f: > > ^^^^^^^^^^^^^^^^^^^^ > > ValueError: invalid mode: 'rU' > > > > The python 3 documentation [1] says: > > > > There is an additional mode character permitted, 'U', which no > > longer has any effect, and is considered deprecated. It > > previously enabled universal newlines in text mode, which > > became the default behaviour in Python 3.0. Refer to the > > documentation of the newline parameter for further details. > > > > [1] - https://docs.python.org/3.9/library/functions.html#open > > > > This patch fixes this issue. > > > > Signed-off-by: Numan Siddique <[email protected]> > > --- > > Looks good to me, thanks! > > Acked-by: Dumitru Ceara <[email protected]>
Thanks. I applied this patch to main and backported to branch-22.06 and branch-22.03. Numan > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
