Hi Mike, Amber,
Thanks for working on this. Couple of comments below, rest looks good.
> -----Original Message-----
> From: dev <ovs-dev-boun...@openvswitch.org> On Behalf Of Amber, Kumar
> Sent: Friday, July 22, 2022 2:36 PM
> To: d...@openvswitch.org
> Cc: Ilya Maximets <i.maxim...@redhat.com>
> Subject: Re: [ovs-dev] [PATCH] system-dpdk: Add testpmd clean up in MTU
> unit tests.
>
> Hi Michael,
>
>
> The Regression looks good, and the patch looks good too.
> Regression CI runs are added as Screenshots.
Amber, the screenshots are stripped away. (Mail-list strips attachments)
>
> Acked-by: Kumar Amber <kumar.am...@intel.com>
>
>
>
> > -----Original Message-----
> > From: Phelan, Michael <michael.phe...@intel.com>
> > > Fixes: bf47829116a8feb54fe795aa19915f6e6283af93 ("tests: Add OVS-
> > DPDK
> > > MTU unit tests.")
To be consistent, only the first 12 chars of the commit id are sufficient, so
this becomes:
Fixes: bf47829116a8 ("tests: Add OVS-DPDK MTU unit tests.")
But I guess this can be changed when applying, so might not require another
revision.
With that,
Acked-by: Sunil Pai G <sunil.pa...@intel.com>
You might want to add the following alias to your git config to generate the
fixes string easily:
git config --global alias.fixline " log -1 --abbrev=12 --format='Fixes: %h
(\"%s\")%nCc: %ae'"
and use it as: git fixline <commit_id>
> > > Signed-off-by: Michael Phelan <michael.phe...@intel.com>
Since this was reported by Ilya:
Reported-by: Ilya Maximets <i.maxim...@ovn.org>
> > > ---
> > > tests/system-dpdk.at | 11 +++++++++++
> > > 1 file changed, 11 insertions(+)
> > >
<snipped>
Thanks and regards
Sunil
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
