On 7/25/22 10:58, Eelco Chaudron wrote:
>
>
> On 25 Jul 2022, at 10:19, David Marchand wrote:
>
>> On my Fedora 36, the test with enabled offloads often fails with one of
>> those ping failing.
>> By chance (?), the previous tcpdumps are not stopped and I can see for
>> example:
>> 10:04:02.534492 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 2,
>> length 72
>> 10:04:02.639443 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 3,
>> length 72
>> 10:04:02.743447 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 4,
>> length 72
>> 10:04:02.846447 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 5,
>> length 72
>> 10:04:02.950519 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 6,
>> length 72
>> 10:04:03.054697 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 7,
>> length 72
>> 10:04:03.158448 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 8,
>> length 72
>> 10:04:03.262541 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 9,
>> length 72
>> 10:04:03.366444 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 10,
>> length 72
>> 10:04:03.466501 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 11,
>> length 72
>>
>> The first ping request has not been handled correctly.
>>
>> Adding a sleep 1 (like other offloads unit tests) seems to be enough to
>> avoid this situation.
>>
>> Fixes: 02dabb21f243 ("tests: Add check_pkt_len action test to
>> system-offload-traffic.")
>> Signed-off-by: David Marchand <[email protected]>
>
> Looks good to me. Did a loop test on my system and now failures after 100
> runs :)
>
> Acked-by: Eelco Chaudron <[email protected]>
>
Thanks! Applied to master and branch-3.0.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
