On Thu, Jul 28, 2022 at 5:00 PM Frode Nordahl <[email protected]> wrote: > > > This is only a suggestion to avoid adding too many -Wl options as they > > > stack up if you are not careful. > > > > I see. Though, it is probably not a big concern for this particular > > use-case. > > > > I can replace '-Wl,-Bstatic -lopenvswitch -Wl,-Bdynamic' with > > '-l:libopenvswitch.a' and send a new version, or replace on commit, > > if you think that will be better. I don't have a strong preference. > > > > What do you think? > > > > Frode, do you have any comments on this? > > David, thank you for sharing the `-l:` syntax, I was not aware of that. > > I have no strong opinions about what to use, if it helps to tip the > scale, I have to admit in this specific use-case where we only have > two of these, the longer syntax appears more clear on the tin to see > what's going on. We could switch to `-l:` if we need to add more of > these for example?
Ok for me, so let's go with the current form. The whole series lgtm. With the nit on patch 2 commitlog, for the series, Reviewed-by: David Marchand <[email protected]> -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
