On 8/4/22 16:57, Paul Blakey wrote:
> On 29/07/2022 17:53, Ilya Maximets wrote:
>> @@ -1431,6 +1434,19 @@ parse_put_flow_set_action(struct tc_flower *flower,
>> struct tc_action *action,
>> action->encap.ttl = nl_attr_get_u8(tun_attr);
>> }
>> break;
>> + case OVS_TUNNEL_KEY_ATTR_DONT_FRAGMENT: {
>> + /* XXX: This is wrong! We're ignoring the DF flag configuration
>> + * requested by the user. However, TC for now has no way to
>> pass
>> + * that flag and it is set by default, meaning tunnel offloading
>> + * will not work if 'options:df_default=false' is not set.
>> + * Keeping incorrect behavior for now. */
>> + }
>> + break;
>> + case OVS_TUNNEL_KEY_ATTR_CSUM: {
>> + attr_csum_present = true;
>> + action->encap.no_csum = !nl_attr_get_u8(tun_attr);>
> Hi, OVS_TUNNEL_KEY_ATTR_CSUM is a flag (zero size, not u8), so maybe you meant
> setting action->encap.no_csum = 0; instead
Hmm, you're right. Got confused with TCA_TUNNEL_KEY_NO_CSUM, I guess.
Will fix in v3. Thanks!
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
