Yesterday I created a patch: https://patchwork.ozlabs.org/project/ovn/patch/20220804145543.8294-1-fsb4...@yandex.ru/ I hope it solves all the problems. Maybe I should have written to this thread right away, because you might not see
> On 8/4/22 15:19, Igor Zhukov wrote: > >> Hi. Yes, I confirm. >> I'm sorry :( > > No problem. :) > >> Probably removing >> `|| github.ref` >> will help. > > Makes sense to me to limit it to PRs. But what would be the generated > group name for a plain push event (no PR)? > > Thanks, > Dumitru > >>> Hi guys, >>> >>> It seems to me that this is breaking a bit the patchwork + ovsrobot >>> workflow. For example, for a series of patches the robot will push them >>> one by one, to trigger test runs with each individual patch. >>> >>> Taking a random patch series as example: >>> https://patchwork.ozlabs.org/project/ovn/list/?series=311230 >>> >>> Patch 4/4 failed some tests: >>> https://mail.openvswitch.org/pipermail/ovs-build/2022-July/024055.html >>> https://github.com/ovsrobot/ovn/runs/7509525379?check_suite_focus=true >>> >>> And this caused the runs for patches 1-3/4 to be cancelled: >>> https://github.com/ovsrobot/ovn/actions/runs/2735541538 >>> https://github.com/ovsrobot/ovn/actions/runs/2735538404 >>> https://github.com/ovsrobot/ovn/actions/runs/2735531275 >>> >>> I think it's quite useful to run tests on each individual patch of the >>> series. It makes bisecting a failure easier. >>> >>> Also, it might be a personal preference, but it gives me more confidence >>> if I see a patch series in patchwork having more green icons than red. >>> >>> Do you guys have any other thoughts on this matter? >>> >>> Thanks, >>> Dumitru >>> >>> On 7/14/22 22:02, Numan Siddique wrote: >>> >>>> On Wed, Jul 13, 2022 at 6:53 AM Ales Musil <amu...@redhat.com> wrote: >>>> >>>>> Ok, thanks. >>>>> >>>>> Acked-by: Ales Musil <amu...@redhat.com> >>>> >>>> Thanks. I applied this patch to the main branch. >>>> >>>> Numan >>>> >>>>> On Wed, Jul 13, 2022 at 1:50 PM Igor Zhukov <fsb4...@yandex.ru> wrote: >>>>> >>>>>> Yes, as far as I understand. >>>>>> I found some github repos also use it: >>>>>> https://github.com/TeamAmaze/AmazeFileManager/blob/release/3.7/.github/workflows/android-feature.yml#L10-L12 >>>>>> >>>>>>> Hi Igor, >>>>>>> >>>>>>> IIUC this applies only to PR right? I mean there's no harm in having >>>>>>> that >>>>>>> >>>>>>> just to be sure. >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Ales >>>>>>> >>>>>>> On Wed, Jul 13, 2022 at 1:25 PM Igor Zhukov <fsb4...@yandex.ru> wrote: >>>>>>> >>>>>>>> From: Igor Zhukov <ivzhu...@sbercloud.ru> >>>>>>>> >>>>>>>> While implementing https://github.com/ovn-org/ovn/pull/139 I sometimes >>>>>> >>>>>> pushed >>>>>> >>>>>>>> several commits quickly and after that I noticed that previous run was >>>>>> >>>>>> still in >>>>>> >>>>>>>> progress and the most recent run was waiting in line. >>>>>>>> >>>>>>>> I googled some solutions and >>>>>>>> >>>>>>>> I found the answer: https://stackoverflow.com/a/72408109/4544798 >>>>>>>> >>>>>>>> Github docs: >>>>>> >>>>>> https://docs.github.com/en/actions/using-jobs/using-concurrency >>>>>> >>>>>>>> Signed-off-by: Igor Zhukov <ivzhu...@sbercloud.ru> >>>>>>>> >>>>>>>> Submitted-at: https://github.com/ovn-org/ovn/pull/145 >>>>>>>> >>>>>>>> --- >>>>>>>> >>>>>>>> .github/workflows/ovn-kubernetes.yml | 4 ++++ >>>>>>>> >>>>>>>> .github/workflows/test.yml | 4 ++++ >>>>>>>> >>>>>>>> 2 files changed, 8 insertions(+) >>>>>>>> >>>>>>>> diff --git a/.github/workflows/ovn-kubernetes.yml >>>>>> >>>>>> b/.github/workflows/ovn-kubernetes.yml >>>>>> >>>>>>>> index c05bbd3f9..431e47660 100644 >>>>>>>> >>>>>>>> --- a/.github/workflows/ovn-kubernetes.yml >>>>>>>> >>>>>>>> +++ b/.github/workflows/ovn-kubernetes.yml >>>>>>>> >>>>>>>> @@ -8,6 +8,10 @@ on: >>>>>>>> >>>>>>>> # Run Sunday at midnight >>>>>>>> >>>>>>>> - cron: '0 0 * * 0' >>>>>>>> >>>>>>>> +concurrency: >>>>>>>> >>>>>>>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || >>>>>> >>>>>> github.ref }} >>>>>> >>>>>>>> + cancel-in-progress: true >>>>>>>> >>>>>>>> + >>>>>>>> >>>>>>>> env: >>>>>>>> >>>>>>>> GO_VERSION: "1.17.6" >>>>>>>> >>>>>>>> K8S_VERSION: v1.23.3 >>>>>>>> >>>>>>>> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml >>>>>>>> >>>>>>>> index e0de7c60e..56e8ba870 100644 >>>>>>>> >>>>>>>> --- a/.github/workflows/test.yml >>>>>>>> >>>>>>>> +++ b/.github/workflows/test.yml >>>>>>>> >>>>>>>> @@ -7,6 +7,10 @@ on: >>>>>>>> >>>>>>>> # Run Sunday at midnight >>>>>>>> >>>>>>>> - cron: '0 0 * * 0' >>>>>>>> >>>>>>>> +concurrency: >>>>>>>> >>>>>>>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || >>>>>> >>>>>> github.ref }} >>>>>> >>>>>>>> + cancel-in-progress: true >>>>>>>> >>>>>>>> + >>>>>>>> >>>>>>>> jobs: >>>>>>>> >>>>>>>> build-linux: >>>>>>>> >>>>>>>> env: >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> 2.30.2 >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> >>>>>>>> dev mailing list >>>>>>>> >>>>>>>> d...@openvswitch.org >>>>>>>> >>>>>>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Ales Musil >>>>>>> >>>>>>> Senior Software Engineer - OVN Core >>>>>>> >>>>>>> Red Hat EMEA >>>>>>> >>>>>>> amu...@redhat.com >>>>>>> >>>>>>> IM: amusil >>>>> >>>>> -- >>>>> >>>>> Ales Musil >>>>> >>>>> Senior Software Engineer - OVN Core >>>>> >>>>> Red Hat EMEA <https://www.redhat.com> >>>>> >>>>> amu...@redhat.com IM: amusil >>>>> <https://red.ht/sig> >>>>> _______________________________________________ >>>>> dev mailing list >>>>> d...@openvswitch.org >>>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>>> >>>> _______________________________________________ >>>> dev mailing list >>>> d...@openvswitch.org >>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
