On Thu, Aug 11, 2022 at 7:34 PM Mark Michelson <[email protected]> wrote: > Much like Numan said in his reply to patch 4, I don't have much > expertise in the realm of debian packaging. I took a look through the > series, just looking for anything that was obviously incorrect, and I > couldn't find it. I trust that if there are issues, you will likely > follow up with corrections. So from that point of view, > > Acked-by: Mark Michelson <[email protected]>
I do indeed intend to keep this maintained and help tackle any issues that arise. Thanks! > I do have some questions, though. In patch 4, you added multiple > flaky-tests text files. What do these files do? Do they somehow tell the > packager that it's OK if these tests fail? Are these tests re-run if > they fail the first time in the hope they pass after a second run? How > did you determine which tests to add to these files? Are there any > documented failures that OVN developers could look at in order to try to > reduce the flakiness? If a non-Debian developer does work to try to > reduce the flakiness of any of those tests, then should they feel free > to also remove the test from the file? During package building the testsuite is executed with RECHECK=yes, and a package will not be accepted for upload if the test execution fails. The packages in the archive are also rebuilt from time to time, and if there are any failing tests at that point in time it may hold up a coordinated release of rebuilt packages. So it's quite important to ensure a predictable outcome so that we don't get any surprises down the line. As we know there are unfortunately some flaky tests in the OVN testsuite still, although a considerable effort has gone into making them more stable. Previously we simply had a allow-list for which tests to run based on the autotest test numbers, but as OVN develops and new tests are added and the test matrix is expanded these numbers of course change. So we decided to create a simple Python script that determines the test list at runtime based on the test description and we track those to avoid in those textfiles. Package builders are quite busy systems, and for some architectures the build may even occur under full system emulation where the host is using a foreign architecture (i.e. limited acceleration). As you can imagine this would quickly expose any timing related bugs in the test suite. I'm not sure if we keep historic build failures around, so my hunch would be that the only documentation we have is the maintainer updating the git history of the package. But I'll check if there are some records available from Debian/Ubuntu builders. If anyone contributes to fix the flakiness of a test they are also welcome to remove it from these lists, yes! -- Frode Nordahl > On 8/5/22 16:34, Frode Nordahl wrote: > > Debian and Ubuntu is merging their package sources and we have also been > > helping out refreshing the debian package source in the openvswitch > > tree [0]. > > > > This series follows on the back of that work and provides a similar > > update to the OVN tree. > > > > 0: > > https://patchwork.ozlabs.org/project/openvswitch/list/?series=309651&state=%2A&archive=both > > > > Frode Nordahl (5): > > treewide: Fix various typos in manual pages > > debian: Archive the debian package source. > > checkpatch Ignore line length and leading whitespace for debian/*. > > debian: Update debian package source. > > ci: Add jobb for building the deb package. > > > > .ci/linux-build.sh | 33 + > > .ci/linux-prepare.sh | 6 + > > .github/workflows/test.yml | 49 ++ > > build-aux/initial-tab-whitelist | 3 +- > > controller/ovn-controller.8.xml | 2 +- > > debian/.gitignore | 5 +- > > debian/automake.mk | 76 +- > > debian/compat | 1 - > > debian/control | 191 ++++- > > debian/copyright.in | 805 ++++-------------- > > debian/dirs | 2 - > > debian/flaky-tests-amd64.txt | 6 + > > debian/flaky-tests-arm64.txt | 5 + > > debian/flaky-tests-armel.txt | 7 + > > debian/flaky-tests-armhf.txt | 9 + > > debian/flaky-tests-i386.txt | 8 + > > debian/flaky-tests-mips64el.txt | 5 + > > debian/flaky-tests-mipsel.txt | 21 + > > debian/flaky-tests-ppc64el.txt | 6 + > > debian/flaky-tests-riscv64.txt | 6 + > > debian/flaky-tests-s390x.txt | 5 + > > debian/gbp.conf | 13 + > > debian/not-installed | 5 + > > ...n-central.template => ovn-central.default} | 0 > > debian/ovn-central.dirs | 1 - > > debian/ovn-central.init | 60 -- > > debian/ovn-central.install | 3 - > > debian/ovn-central.manpages | 2 - > > debian/ovn-central.ovn-northd.service | 15 + > > .../ovn-central.ovn-ovsdb-server-nb.service | 18 + > > .../ovn-central.ovn-ovsdb-server-sb.service | 18 + > > debian/ovn-central.postinst | 49 -- > > debian/ovn-central.postrm | 11 +- > > debian/ovn-central.service | 16 + > > debian/ovn-common.docs | 1 + > > debian/ovn-common.install | 28 +- > > debian/ovn-common.logrotate | 22 + > > debian/ovn-common.manpages | 13 - > > debian/ovn-common.postinst | 3 +- > > debian/ovn-common.postrm | 1 - > > debian/ovn-controller-vtep.init | 54 -- > > debian/ovn-controller-vtep.manpages | 1 - > > debian/ovn-controller-vtep.service | 16 + > > debian/ovn-doc.doc-base | 9 + > > debian/ovn-doc.install | 1 + > > debian/ovn-docker.install | 2 + > > .../{ovn-host.template => ovn-host.default} | 0 > > debian/ovn-host.dirs | 1 - > > debian/ovn-host.init | 54 -- > > debian/ovn-host.manpages | 1 - > > debian/ovn-host.ovn-controller.service | 15 + > > debian/ovn-host.postinst | 49 -- > > debian/ovn-host.postrm | 3 +- > > debian/ovn-host.service | 14 + > > debian/ovn-ic-db.install | 2 + > > .../ovn-ic-db.ovn-ovsdb-server-ic-nb.service | 15 + > > .../ovn-ic-db.ovn-ovsdb-server-ic-sb.service | 15 + > > debian/ovn-ic-db.service | 15 + > > debian/ovn-ic.install | 1 + > > debian/ovn-ic.service | 16 + > > debian/rules | 124 ++- > > debian/source/include-binaries | 1 + > > debian/testlist.py | 72 ++ > > debian/watch | 5 + > > northd/ovn-northd.8.xml | 24 +- > > ovn-architecture.7.xml | 6 +- > > ovn-ic-sb.xml | 2 +- > > ovn-nb.xml | 4 +- > > ovn-sb.xml | 2 +- > > utilities/checkpatch.py | 4 +- > > utilities/ovn-ctl.8.xml | 3 +- > > utilities/ovn-nbctl.8.xml | 8 +- > > utilities/ovn-sbctl.8.xml | 2 +- > > 73 files changed, 959 insertions(+), 1112 deletions(-) > > delete mode 100644 debian/compat > > delete mode 100644 debian/dirs > > create mode 100644 debian/flaky-tests-amd64.txt > > create mode 100644 debian/flaky-tests-arm64.txt > > create mode 100644 debian/flaky-tests-armel.txt > > create mode 100644 debian/flaky-tests-armhf.txt > > create mode 100644 debian/flaky-tests-i386.txt > > create mode 100644 debian/flaky-tests-mips64el.txt > > create mode 100644 debian/flaky-tests-mipsel.txt > > create mode 100644 debian/flaky-tests-ppc64el.txt > > create mode 100644 debian/flaky-tests-riscv64.txt > > create mode 100644 debian/flaky-tests-s390x.txt > > create mode 100644 debian/gbp.conf > > create mode 100644 debian/not-installed > > rename debian/{ovn-central.template => ovn-central.default} (100%) > > delete mode 100644 debian/ovn-central.dirs > > delete mode 100755 debian/ovn-central.init > > delete mode 100644 debian/ovn-central.manpages > > create mode 100644 debian/ovn-central.ovn-northd.service > > create mode 100644 debian/ovn-central.ovn-ovsdb-server-nb.service > > create mode 100644 debian/ovn-central.ovn-ovsdb-server-sb.service > > delete mode 100755 debian/ovn-central.postinst > > mode change 100755 => 100644 debian/ovn-central.postrm > > create mode 100644 debian/ovn-central.service > > create mode 100644 debian/ovn-common.docs > > create mode 100644 debian/ovn-common.logrotate > > delete mode 100644 debian/ovn-common.manpages > > delete mode 100755 debian/ovn-controller-vtep.init > > delete mode 100644 debian/ovn-controller-vtep.manpages > > create mode 100644 debian/ovn-controller-vtep.service > > create mode 100644 debian/ovn-doc.doc-base > > create mode 100644 debian/ovn-doc.install > > create mode 100644 debian/ovn-docker.install > > rename debian/{ovn-host.template => ovn-host.default} (100%) > > delete mode 100644 debian/ovn-host.dirs > > delete mode 100755 debian/ovn-host.init > > delete mode 100644 debian/ovn-host.manpages > > create mode 100644 debian/ovn-host.ovn-controller.service > > delete mode 100755 debian/ovn-host.postinst > > mode change 100755 => 100644 debian/ovn-host.postrm > > create mode 100644 debian/ovn-host.service > > create mode 100644 debian/ovn-ic-db.install > > create mode 100644 debian/ovn-ic-db.ovn-ovsdb-server-ic-nb.service > > create mode 100644 debian/ovn-ic-db.ovn-ovsdb-server-ic-sb.service > > create mode 100644 debian/ovn-ic-db.service > > create mode 100644 debian/ovn-ic.install > > create mode 100644 debian/ovn-ic.service > > create mode 100644 debian/source/include-binaries > > create mode 100755 debian/testlist.py > > create mode 100644 debian/watch > > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
