On 19 Aug 2022, at 21:51, Ilya Maximets wrote:
> Cited commit correctly fixed the issue of incorrect reporting
> of zero-length geneve option matches as wildcarded. But as a
> side effect, exact match on the metadata length was added to
> every tunnel flow match, even if the tunnel is not geneve.
> That doesn't generate any functional issues, but it maybe
> confusing to see 'tunnel(...,geneve(),...)' while looking at
> datapath flow dumps for, e.g., vxlan tunnel flows.
>
> Fix that by checking the port type before parsing geneve options.
> tunnel() attribute itself doesn't have enough information to
> figure out the tunnel type.
>
> Fixes: 7a6c8074c5d2 ("netdev-offload-tc: Fix the mask for tunnel metadata
> length.")
> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
Changes look good to me, did some basic tunnel tests and they look fine.
Acked-by: Eelco Chaudron <echau...@redhat.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
