On 8/29/22 12:02, Eelco Chaudron wrote:
> This change will terminate tcpdump between each test case to avoid
> confusion when analyzing results.
>
> Fixes: 02dabb21f243 ("tests: Add check_pkt_len action test to
> system-offload-traffic.")
> Suggested-by: David Marchand <[email protected]>
> Signed-off-by: Eelco Chaudron <[email protected]>
> ---
> tests/system-offloads-traffic.at | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tests/system-offloads-traffic.at
> b/tests/system-offloads-traffic.at
> index 1e1012965..7260654b0 100644
> --- a/tests/system-offloads-traffic.at
> +++ b/tests/system-offloads-traffic.at
> @@ -324,11 +324,12 @@ AT_CHECK([ovs-appctl dpctl/dump-flows
> type=tc,offloaded], [0], [])
> AT_CHECK([test $(ovs-appctl upcall/show | grep -c "offloaded flows") -eq 0],
> [0], [ignore])
>
> OVS_TRAFFIC_VSWITCHD_STOP
> +kill $(pidof tcpdump)
Can we just use NETNS_DAEMONIZE() to start tcpdump in the first place?
Should we also do that in all other system tests?
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
