On 8/4/22 18:07, Paolo Valerio wrote: > Some of the CTA_PROTOINFO_TCP nested attributes are not always > included in the received message, but the parsing logic considers them > as required, failing in case they are not found. > > This was observed while monitoring some connections by reading the > events sent by conntrack: > > ./ovstest test-netlink-conntrack monitor > [...] > 2022-08-04T09:39:02Z|00007|netlink_conntrack|ERR|Could not parse nested TCP > protoinfo > options. Possibly incompatible Linux kernel version. > 2022-08-04T09:39:02Z|00008|netlink_notifier|WARN|unexpected netlink message > contents > [...] > > All the TCP DELETE/DESTROY events fail to parse with the message > above. > > Fix it by turning the relevant attributes to optional. > > Signed-off-by: Paolo Valerio <[email protected]> > --- > - [1] is the related piece of code that skips flags and wscale for the > destroy evts. > > [1] > https://github.com/torvalds/linux/blob/master/net/netfilter/nf_conntrack_proto_tcp.c#L1202 > --- > lib/netlink-conntrack.c | 45 +++++++++++++++++++++++++++------------------ > 1 file changed, 27 insertions(+), 18 deletions(-)
Thanks! I applied this one patch. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
