On 8/29/22 22:49, Han Zhou wrote:
> On Mon, Aug 29, 2022 at 2:27 AM Xavier Simonart <[email protected]> wrote:
>>
>> If a logical switch port is added and connected to a logical router
>> port (through options: router-port) before the router port is
>> created, then this might cause further issues such as segmentation
>> violation when the switch and router ports are deleted.
>>
>> Signed-off-by: Xavier Simonart <[email protected]>
>>
>> ---
>> v2: - handled Han's comments (avoid wasting CPU cycles searching for
> peer_ld)
>> v3: - handled additional case causing potential crash
>> - add test case covering this additional potential crash
>> - remove ofport-request from test case
>> - rebased on origin/main
>> ---
>> controller/local_data.c | 38 +++++++-----------
>> controller/pinctrl.c | 16 ++++++--
>> tests/ovn.at | 89 +++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 117 insertions(+), 26 deletions(-)
>
> Thanks again Xavier. I applied to main and backported to 22.06 and 22.03.
>
> Han
Hey, Han and Xavier.
Not sure if it is the same or similar issue, but I caught this today:
../../controller/binding.c:2515:42: runtime error: member access within null
pointer of type 'struct sbrec_datapath_binding'
#0 0x4dd10f in handle_deleted_lport
/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/../../controller/binding.c:2515:42
#1 0x4dcc74 in handle_deleted_vif_lport
/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/../../controller/binding.c:2587:5
#2 0x4da9aa in binding_handle_port_binding_changes
/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/../../controller/binding.c:2908:19
#3 0x5be01b in runtime_data_sb_port_binding_handler
/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/../../controller/ovn-controller.c:1622:10
#4 0x67b9fe in engine_compute
/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/../../lib/inc-proc-eng.c:403:28
#5 0x67a260 in engine_run_node
/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/../../lib/inc-proc-eng.c:465:14
#6 0x6798f1 in engine_run
/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/../../lib/inc-proc-eng.c:490:9
#7 0x5ac053 in main
/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/../../controller/ovn-controller.c
#8 0x7f92c25a6082 in __libc_start_main
(/lib/x86_64-linux-gnu/libc.so.6+0x24082)
#9 0x41fe7d in _start
(/home/runner/work/ovn/ovn/ovn-22.09.90/_build/sub/controller/ovn-controller+0x41fe7d)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../../controller/binding.c:2515:42 in
Here is a failed job:
https://github.com/igsilya/ovn/runs/8162460040?check_suite_focus=true#step:13:5493
The branch is a latest main branch with the fix already applied.
There are some northd changes, but only pure performance, no
logical changes. And no ovn-controller changes.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
