On 9/7/22 22:26, Ilya Maximets wrote: > If the same load balancer group is attached to multiple routers, > IP sets will be constructed for each of them by sequentially calling > sset_add() for each IP for each load balancer for each router. > Instead of doing that, we can create IP sets for load balancer > groups and clone them. That will avoid extra ssed_find__() call > making the construction of IP sets 2x faster. > > Only first load balancer group is cloned, the rest as well as > standalone load balancers are still added one by one, because > there is no more efficient way to merge sets. > > The order of processing changed to make sure that we're actually > optimizing copy of a large group. > > The code can be optimized further by introduction of a reference > counter and not copying at all if the router has no standalone load > balancers and only one group. Also, construction of "reachable" > sets can be optimized for the "neighbor_responder = all" case. But, > for now, only moved to a new structure for better readability. > > Acked-by: Dumitru Ceara <[email protected]> > Signed-off-by: Ilya Maximets <[email protected]> > ---
Still looks good to me, thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
