On 8/1/22 20:48, Timothy Redaelli wrote:
> Since on CentOS/RHEL the builds are based on stable branches and not on
> tags for debugging purpose it's better to have the downstream version as
> version so it's easier to know which commits are included in a build.
That makes sense to me. See some comments inline.
>
> This commit adds DISPLAY_VERSION as ./configure environment variable in
> order to set an OVS version that should be shown to the user via
> ovs-vsctl -V and, so, also on database and on ovs-vsctl show.
What about versions printed in a log file? This patch also doesn't cover
versions printed by some utilities, especially python-based. It will be
confusing to have different versions printed in different places.
>
> DISPLAY_VERSION is used in Fedora/CentOS/RHEL spec file in order to have
> the version be aligned with the downstream one.
Allowing users to fully replace the version string doesn't seem like a good
approach, and it also doesn't seem to be needed.
The patch changes the version for fedora builds to %{version}-%{release},
so it looks like that we only need a version suffix, not the whole version
string. This way we can also use the ARG_WITH instead of ARG_VAR. It just
looks better, IMO. E.g. --with-version-suffix=%{release}.
What do you think?
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
