On 9/1/22 18:02, Eelco Chaudron wrote:
> Using [NETNS|OVS]_DAEMONIZE will start tcpdump in the background,
> and it will also make sure it gets killed in corner cases.
>
> For the check_pkt_len tests, we also kill tcpdump between individual
> tests in the same test case to avoid confusion when analyzing results.
> This also required some changes to the awk expressions, as an extra
> newline is added to the output when tcpdump gets stopped.
>
> Fixes: 02dabb21f243 ("tests: Add check_pkt_len action test to
> system-offload-traffic.")
> Suggested-by: David Marchand <[email protected]>
> Signed-off-by: Eelco Chaudron <[email protected]>
> ---
> v3:
> - Fixed the suggested-by line
> - Updated commit message on newline change
> - Fixed some more invocations of tcpdump in namespaces
> - Fixed none netns daemonize of tcpdump also
> v2:
> - Replaced NS_CHECK_EXEC with NETNS_DAEMONIZE for all tcpdump use cases.
Thanks, Eelco and David! Applied and backported to 3.0.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
