"Fengqi Li (李丰启)" <[email protected]> writes: > My ovs version is 2.13.2 and I checked the ff8decf1a318 commit .Ovs 2.13.2 > contains this commit and this bug still exists. I also checked the matser > branch and it may also have the same problem. > By the way,is there any way to change the title?
The request is to submit a v2 with the changes made to that version. Thanks so much! > Fengqi Li <[email protected]> writes: > >> when segmentation fault occured in ovn-northd,monitor will try to >> restart the ovn-northd daemon process every 10s. >> Assume the following scenarios: There is a segmentation fault and the >> ovn-northd daemon process does not restart properly everytime. >> New fds are created each time the ovn-northd daemon process is >> restarted by the monitor process,but old fds(fd[1]) ownered by the >> monitor process not closed properly.One pipe remains for each restart >> of the ovn-northd daemon process,After a long time the OS`s pipe are >> exhausted. >> >> Signed-off-by: Fengqi Li <[email protected]> >> --- > > The bug here is really that we leak file descriptors in the case that the > monitor process needs to restart. Commit message probably doesn't need to > include specific daemon names except as an illustration. > > Title should be something like: > > daemon-unix: Fix file descriptpr leak when monitor restarts child > > We probably could include a fixes: line here (but it is an incredibly old > bug, so maybe it can be omitted): > > Fixes: ff8decf1a318 ("daemon: Add support for process monitoring and > restart.") _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
