On 9/14/22 16:19, Simon Horman wrote: > From: Tianyu Yuan <[email protected]> > > Since dd9881ed55e6 ("tc: Fix stats dump when using same meter table") > rule stats update will ignore meter police. Correspondingly, the > reference stats of the test should also be modified to ensure the test > could pass correctly. > > Fixes: dd9881ed55e6 ("tc: Fix stats dump when using same meter table") > Signed-off-by: Tianyu Yuan <[email protected]> > Signed-off-by: Simon Horman <[email protected]> > --- > tests/system-offloads-traffic.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/system-offloads-traffic.at > b/tests/system-offloads-traffic.at > index d9b815a5ddf4..24e49d42f589 100644 > --- a/tests/system-offloads-traffic.at > +++ b/tests/system-offloads-traffic.at > @@ -264,7 +264,7 @@ NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u > 10.1.1.2 5678 -p 6789]) > done > > AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED], > [0], [dnl > -in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:10, > bytes:330, used:0.001s, actions:meter(0),3 > +in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:1, > bytes:33, used:0.001s, actions:meter(0),3
This looks very strange to me. The test does send 10 packets. Why the flow should report only one? > ]) > > AT_CHECK([ovs-ofctl -O OpenFlow13 meter-stats br0 | sed -e > 's/duration:[[0-9]].[[0-9]]*s/duration:0.001s/'], [0], [dnl These meter stats are correctly reporting 11 packets, so the datapath flow should report 10 (+1 on the upcall), AFAIU. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
