On 9/13/22 14:59, Emma Finn wrote:
> This commit adds support for the AVX512 implementation of the
> ipv6_set_addrs action as well as an AVX512 implementation of
> updating the L4 checksums.
>
> Signed-off-by: Emma Finn <[email protected]>
> ---
> lib/odp-execute-avx512.c | 163 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 163 insertions(+)
>
> diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c
> index 6c7713251..c4806f2e2 100644
> --- a/lib/odp-execute-avx512.c
> +++ b/lib/odp-execute-avx512.c
> @@ -20,6 +20,7 @@
>
> #include <config.h>
> #include <errno.h>
> +#include <netinet/ip6.h>
Hi. Not a review, but a note that this patch is breaking FreeBSD
builds as it is using non-standard fields like s6_addr32 of struct
in6_addr without checking their availability. You may find examples
on how other parts of OVS handle that in the code.
Also, FreeBSD requires a certain order in which networking headers
should be included. See the following commit for details:
b2befd5bb2db ("sparse: Add guards to prevent FreeBSD-incompatible #include
order.")
We seem to need one more guard for ip6.h though, but that's a
different story. I'll try to cook up the patch for that.
And you may find failed cirrus CI jobs here:
https://cirrus-ci.com/build/5914014558453760
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
