On Tue, Sep 13, 2022 at 1:19 PM Han Zhou <[email protected]> wrote: > > On Mon, Sep 12, 2022 at 3:25 AM Dumitru Ceara <[email protected]> wrote: > > > > On 9/9/22 23:32, Ilya Maximets wrote: > > > Re-compute of 'northd' node in ovn-northd may take almost half of the > > > total processing time in case there is a big number of load balancers > > > applied to multiple switches/routers or if there are huge load balancer > > > groups applied to them. The latter is a common case for ovn-kubernetes > > > clusters. > > > > > > This patch set is a result of profiling ovn-northd in ovn-heater > > > density-heavy scenario with 500 fake nodes, which supposed to resemble > > > high scale ovn-kubernetes setups. > > > > > > There are no functional changes, only mechanical optimizations that > > > allows to achieve exactly the same result by doing less work. > > > > > > In total these patches allowed to speed up ovn-northd in the > > > aforementioned scenario by about 40%. For exmaple, average northd > > > poll interval went down from 19.7 seconds to 10.2 seconds. And the > > > maximum poll interval reduced from 31.7 to 14.9 seconds. > > > > > > > > > Version 2: > > > - Moved LB-specific structures and function to lib/lb.[c,h]. > > > - 'ods' array in struct ovn_lb_group split in two: ls and lr. > > > - Added missed handling of 'skip_snat' and 'event' options. > > > - Minor re-base/re-factor. > > > - Added 'Acked-by' from Dumitru to patches 1 and 4. > > > > > > Version 3: > > > - Code to manage struct ovn_lb_group split into separate functions > > > in lib/lb.[c,h]: > > > * ovn_lb_group_create() > > > * ovn_lb_group_destroy() > > > * ovn_lb_group_add_ls/lr() > > > - Added 'Acked-by' from Dumitru to remaining patches. > > > > > > > I had another look at this version and the patches look good to go to > > me; thanks! > > > Thanks Ilya and Dumitru. > Now that this series is merged to main. Shall we discuss/vote if it is > required to be backported? Dumitru has proposed it to be backported down to > the LTS branch-22.03. > Although it is not a bug fix, it seems to be important for large scale > environments with heavy LB usage. Any objections?
No objections from my side. Thanks Numan > > Thanks, > Han > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
