Hi David, Generally, looks good, one minor nit inline.
> -----Original Message----- > From: dev <[email protected]> On Behalf Of David Marchand > Sent: Thursday, August 25, 2022 3:55 PM > To: [email protected] > Subject: [ovs-dev] [PATCH 3/3] netdev-dpdk: Cleanup mempool selection > code. > > Propagating per_port_memory value through a DPDK netdev creation gives the > false impression its value is somehow contextual to the creation. > > On the contrary, this parameter value is set once and for all at OVS > initialisation time. Nit: should be "initialization" ? > > Simplify the code and directly access the local boolean. > > Signed-off-by: David Marchand <[email protected]> > --- > lib/netdev-dpdk.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > Otherwise, Acked-by: Sunil Pai G <[email protected]> <snipped> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
