On Thu, Sep 22, 2022 at 08:45:19AM -0500, Alex Elder wrote: > On 9/21/22 10:10 PM, Kees Cook wrote: > > Instead of discovering the kmalloc bucket size _after_ allocation, round > > up proactively so the allocation is explicitly made for the full size, > > allowing the compiler to correctly reason about the resulting size of > > the buffer through the existing __alloc_size() hint. > > > > Cc: Alex Elder <[email protected]> > > Cc: "David S. Miller" <[email protected]> > > Cc: Eric Dumazet <[email protected]> > > Cc: Jakub Kicinski <[email protected]> > > Cc: Paolo Abeni <[email protected]> > > Cc: [email protected] > > Signed-off-by: Kees Cook <[email protected]> > > --- > > drivers/net/ipa/gsi_trans.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c > > index 18e7e8c405be..cec968854dcf 100644 > > --- a/drivers/net/ipa/gsi_trans.c > > +++ b/drivers/net/ipa/gsi_trans.c > > @@ -89,6 +89,7 @@ int gsi_trans_pool_init(struct gsi_trans_pool *pool, > > size_t size, u32 count, > > u32 max_alloc) > > { > > void *virt; > > + size_t allocate; > > I don't care about this but the reverse Christmas tree > convention would put the "allocate" variable definition > above "virt".
Oops, yes; thank you! -Kees -- Kees Cook _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
