On 9/20/22 09:12, Ales Musil wrote:
> 
> 
> On Fri, Sep 16, 2022 at 5:50 PM Dumitru Ceara <[email protected] 
> <mailto:[email protected]>> wrote:
> 
>     Part of the uuidset implementation is taken from the OVN codebase where
>     it was added via commit 0e77b3bcbfe2 ("ovn-northd-ddlog: New
>     implementation of ovn-northd based on ddlog.").
> 
>     We now extend that, adding a few helpers and tests.
> 
>     Co-authored-by: Leonid Ryzhyk <[email protected] 
> <mailto:[email protected]>>
>     Signed-off-by: Leonid Ryzhyk <[email protected] 
> <mailto:[email protected]>>
>     Co-authored-by: Justin Pettit <[email protected] <mailto:[email protected]>>
>     Signed-off-by: Justin Pettit <[email protected] <mailto:[email protected]>>
>     Co-authored-by: Ben Pfaff <[email protected] <mailto:[email protected]>>
>     Signed-off-by: Ben Pfaff <[email protected] <mailto:[email protected]>>
>     Signed-off-by: Dumitru Ceara <[email protected] 
> <mailto:[email protected]>>
>     ---
>     Note: I wasn't sure if I should keep Leonid as main author so I added a
>     "Co-authored-by" tag.  I can amend that and send a v2 if needed.
>     ---
>      lib/automake.mk <http://automake.mk>      |  2 +
>      lib/uuidset.c        | 99 ++++++++++++++++++++++++++++++++++++++++++++
>      lib/uuidset.h        | 71 +++++++++++++++++++++++++++++++
>      tests/.gitignore     |  1 +
>      tests/automake.mk <http://automake.mk>    |  1 +
>      tests/library.at <http://library.at>     |  4 ++
>      tests/test-uuidset.c | 72 ++++++++++++++++++++++++++++++++
>      7 files changed, 250 insertions(+)
>      create mode 100644 lib/uuidset.c
>      create mode 100644 lib/uuidset.h
>      create mode 100644 tests/test-uuidset.c
>
> Looks good to me, thanks.
> The robot ERROR seems to be a false positive.
> 
> Reviewed-by: Ales Musil <[email protected] <mailto:[email protected]>>

Applied.  Thanks!

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to