On 9/9/22 09:57, Dumitru Ceara wrote:
> On 8/30/22 12:02, Dumitru Ceara wrote:
>> On 8/29/22 13:30, Xavier Simonart wrote:
>>> active_v4_flows count was intialized when the northd node was computed.
>>> However, neither sb_multicast_group nor en_sb_igmp_group causes northd
>>> updates. Hence this count could keep increasing while processing igmp
>>> groups.
>>>
>>> This issue was sometimes 'hidden' by northd recomputes due to lflow unable
>>> to be incrementally processed (sb busy).
>>>
>>> active_v4_flows is now reinitialized right before building flows
>>> (i.e. as part of the lflow node, which is computed on igmp group changes).
>>>
>>> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2094710
>>>
>>> Signed-off-by: Xavier Simonart <[email protected]>
>> Looks good to me, thanks!
>>
>> Acked-by Dumitru Ceara <[email protected]>
>>
>
> Fixing the ack tag so that patchwork marks it properly:
>
> Acked-by: Dumitru Ceara <[email protected]>
>
>>> ---
>> Note for the maintainers: there's an extra whitespace before --- which
>> causes the notes below to be added to the commit log when applying the
>> patch. I guess that should be fixed up at apply time.
>>
>> Regards,
>> Dumitru
>>
I applied this to the main branch and backported it to all stable
branches down to branch-22.03.
On branch-22.03 I had to make a small change to the test to account
for table number changes:
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index bfe441ddf..d3eb20978 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -8337,7 +8337,7 @@ ovn-sbctl list ip_multicast
wait_igmp_flows_installed()
{
- OVS_WAIT_UNTIL([ovs-ofctl dump-flows br-int table=31 | \
+ OVS_WAIT_UNTIL([ovs-ofctl dump-flows br-int table=32 | \
grep 'priority=90' | grep "nw_dst=$1"])
}
---
Thanks,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
