On 10/5/22 02:04, Han Zhou wrote: > On Fri, Sep 30, 2022 at 5:49 AM Dumitru Ceara <[email protected]> wrote: >> >> Avoid having to add OVN_FOR_EACH_NORTHD for each test in ovn-northd.at. >> We know that all tests in there should be run for all types of northd >> and w/ or w/o parallelization enabled. Just wrap the whole set of tests >> in a single call to the newly added OVN_FOR_EACH_NORTHD_NO_HV(). >> >> This also fixes the fact that some tests were not run for all flavors of >> northd. >> >> There's one small disadvantage with this approach: two instances of the >> same test in ovn-northd.at will not be consecutive in index anymore, >> e.g.: >> 853: LRP same IP as VIP or SNAT -- ovn-northd -- parallelization=yes ok >> 939: LRP same IP as VIP or SNAT -- ovn-northd -- parallelization=no ok >> > > Hi Dumitru, >
Hi Han, > In fact I am more concerned about this disadvantage. I found it convenient > when the same test cases are kept close to each other when checking > failures during regression tests. > Although I also agree that adding the wrapper for each test case doesn't > seem ideal, but I don't think it is a big deal, and there may be tests that > we want to skip the wrapper on purpose. That's a fair point, thanks for sharing your opinion! > The new _NO_HV macro is definitely useful, and I think it is good to use it > to replace OVN_FOR_EACH_NORTHD for the tests that doesn't require > ovn-controller. Ok. I'll abandon this patch and post a new one that adds this and fixes the missing wrappers where needed. > > Thanks, > Han > Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
