On 10/6/22 17:53, Mike Pattrick wrote: > On Mon, Sep 26, 2022 at 5:19 PM Ilya Maximets <[email protected]> wrote: >> >> Same as arpa/inet.h, the netinet/ip6.h on FreeBSD requires >> netinet/in.h to be included first. So, adding a similar guard. >> >> Also fixing one instance where this is not respected at the moment. >> >> We do have FreeBSD CI these days, but it is still nice to have >> a more clear error message. >> >> Fixes: b2befd5bb2db ("sparse: Add guards to prevent FreeBSD-incompatible >> #include order.") >> Signed-off-by: Ilya Maximets <[email protected]> >> --- >> >> Version 2: >> - Switched the guard from sys/types.h to netinet/in.h since >> struct ip6_addr is defined there. Fixed one instance where >> this is not respected at the moment. >> > > Looks reasonable to me. > > Acked-by: Mike Pattrick <[email protected]> >
Applied. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
