On Fri, Oct 7, 2022 at 1:37 PM Marcelo Leitner <[email protected]> wrote:
>
> On Fri, Oct 07, 2022 at 11:59:42AM -0400, Jamal Hadi Salim wrote:
> > On Fri, Oct 7, 2022 at 11:01 AM Marcelo Leitner <[email protected]> wrote:
> > >
[..]
> >
> > It's mostly how people who offload (not sure about OVS) do it;
> > example some of the switches out there.
>
> You mean with OK, DROP, TRAP or GOTO actions, right?
>
> Because for PIPE, it has:
> } else if (is_tcf_gact_pipe(act)) {
> NL_SET_ERR_MSG_MOD(extack, "Offload of
> \"pipe\" action is not supported");
> return -EOPNOTSUPP;
>
I thought it was pipe but maybe it is OK(in my opinion that is a bad code
for just "count"). We have some (at least NIC) hardware folks on the list.
Note: we could create an alias to PIPE and call it COUNT if it helps.
And yes, in retrospect we should probably have separated out accounting
from the actions in tc. It makes a lot of sense in s/w - and would work fine for
modern hardware but when you dont have as many counters as actions
it's a challenge. Same thing with policers/meters.
cheers,
jamal
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
