<snipped> 

> v7:
> * Reword bridge.rst documentation to better explain the use of the
>   -recirc option and provide examples. This is all based on feedback
>   from Sunil.
> ---
>  Documentation/topics/dpdk/bridge.rst | 32 ++++++++++++++++++++++------
>  lib/dpif-netdev-private-extract.c    | 23 +++++++++++++++++++-
>  lib/dpif-netdev-private-extract.h    |  6 +++++-
>  lib/dpif-netdev-private-thread.h     |  3 +++
>  lib/dpif-netdev.c                    | 23 ++++++++++++++++----
>  5 files changed, 75 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/topics/dpdk/bridge.rst
> b/Documentation/topics/dpdk/bridge.rst
> index 354f1ced1..3bb01888a 100644
> --- a/Documentation/topics/dpdk/bridge.rst
> +++ b/Documentation/topics/dpdk/bridge.rst
> @@ -293,13 +293,29 @@ command also shows whether the CPU supports each
> implementation::
>  An implementation can be selected manually by the following command::
> 
>      $ ovs-appctl dpif-netdev/miniflow-parser-set [-pmd core_id] name \
> -      [study_cnt]
> +      [study_cnt] [-recirc]
> 
> -The above command has two optional parameters: ``study_cnt`` and
> ``core_id``.
> -The ``core_id`` sets a particular packet parsing function to a specific -
> PMD thread on the core.  The third parameter ``study_cnt``, which is
> specific -to ``study`` and ignored by other implementations, means how
> many packets -are needed to choose the best implementation.
> +The above command has three optional parameters: ``study_cnt``,
> +``core_id`` and ``-recirc``. The ``core_id`` sets a particular packet
> +parsing function to a specific PMD thread on the core.  The third
> +parameter ``study_cnt``, which is specific to ``study`` and ignored by
> +other implementations, means how many packets are needed to choose the
> best implementation.
> +
> +The optional ``-recirc`` parameter allows OVS to set the optimized MFEX
> +function for inner packet processing.
> +
> +For example:
> +
> +- ``name``: sets the outer implementation to ``name``, inner defaults
> +to
> +  scalar.
> +
> +- ``name``  + ``recirc``: sets both outer and inner implementations to
> +  ``name``.
> +
> +- ``study`` + ``recirc``: sets outer and inner implementations
> +independently
> +  based on the traffic pattern. The full command is::
> +
> +    $ ovs-appctl dpif-netdev/miniflow-parser-set study -recirc
> 
>  Also user can select the ``study`` implementation which studies the
> traffic for  a specific number of packets by applying all available
> implementations of @@ -322,6 +338,10 @@ following command::
> 
>      $ ovs-appctl dpif-netdev/miniflow-parser-set -pmd 3 scalar
> 
> +``study`` can be selected with packet count and explicit PMD selection
> +along with the ``recirc`` by following command::
> +
> +    $ ovs-appctl dpif-netdev/miniflow-parser-set -pmd 3 study 1024
> + -recirc
> 

This looks much better, thanks for reworking the doc Cian!

Regards
Sunil

<snipped>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to