On 10/20/22 17:12, Han Zhou wrote: > +1 Thanks for the sign! :)
> > On Thu, Oct 20, 2022 at 8:05 AM Dumitru Ceara <[email protected]> wrote: > >> On 10/20/22 14:23, Xavier Simonart wrote: >>> Specifically for: >>> e379e42d47f8 ("ovsdb-idl: Preserve references for rows deleted in same >> IDL run as their insertion.") >>> >>> A OVN test case reproducing the bug (issue when port_binding is >> added/deleted within the >>> same IDL) is also added. >>> >>> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2126450 >>> >>> Signed-off-by: Xavier Simonart <[email protected]> >>> --- >>> ovs | 2 +- >>> tests/ovn.at | 29 +++++++++++++++++++++++++++++ >>> 2 files changed, 30 insertions(+), 1 deletion(-) >>> >>> diff --git a/ovs b/ovs >>> index 6f24c2bc7..64b79581b 160000 >>> --- a/ovs >>> +++ b/ovs >>> @@ -1 +1 @@ >>> -Subproject commit 6f24c2bc769afde0a390ce344de1a7d9c592e5a6 >>> +Subproject commit 64b79581be012db6053e9caead4090f5becbc3b8 >> >> Thanks Xavier for the backport! >> >> Acked-by: Dumitru Ceara <[email protected]> >> >> Mark, Numan, Han, I would like to backport this further down to 22.06 >> and 22.03 but we need to align our CI on those branches to what we have >> on 22.09 and newer. Otherwise we will be triggering a false positive >> memleak report when compiling OVS with -O2 (as Xavier pointed out >> privately). >> >> Ideally, we should run the same CI as on newer branches so I ended up >> with these additional commits to backport to 22.06 and 22.03: >> >> f14e3a48e4 ci: Add missing tests after switch to parallel jobs >> 4d93844b78 OVN-CI: ovn unit tests run in parallel jobs. >> 78eb7a48ba CI-Actions: define matrix as a list >> ef9a20b9a5 ci: Use CFLAGS instead of OVS_CFLAGS >> af37658768 Build tests with asan and ubsan together to reduce CI time. >> e921402c59 ci: Add UB Sanitizer. >> >> It's all mainly CI related work (no functional changes) so, if everyone >> agrees, I can take care of the backport to all stable branches. >> >> Here are links to my github fork if that makes it easier to review: >> https://github.com/dceara/ovn/commits/idl-fix-branch-22.06 >> https://github.com/dceara/ovn/commits/idl-fix-branch-22.03 >> >> I'll wait for a sign before pushing all these. I pushed all these to branches 22.09, 22.06, 22.03. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
