On 10/12/22 16:36, Paolo Valerio wrote: > This patch removes ct_dpif_format_flags() in favor of the existing > format_flags_masked(). > This has the extra bonus of showing keys with empty values as "key=0", > instead of showing "key=". > > E.g., the following: > > NEW tcp,orig=([...]),reply=([...]),id=1800618864, > status=CONFIRMED|SRC_NAT_DONE|DST_NAT_DONE,timeout=120, > protoinfo=(state_orig=SYN_SENT,state_reply=SYN_SENT,wscale_orig=7, > wscale_reply=0,flags_orig=WINDOW_SCALE|SACK_PERM,flags_reply=) > > becomes: > > NEW tcp,orig=([...]),reply=([...]),id=1800618864, > status=CONFIRMED|SRC_NAT_DONE|DST_NAT_DONE,timeout=120, > protoinfo=(state_orig=SYN_SENT,state_reply=SYN_SENT,wscale_orig=7, > wscale_reply=0,flags_orig=WINDOW_SCALE|SACK_PERM,flags_reply=0) > > Signed-off-by: Paolo Valerio <[email protected]> > --- > v2: > - updated commit message (was "ct-dpif: Do not show flag key if empty.") > - instead of hiding the key, ct_dpif_format_flags() got replaced by > format_flags_masked() which will show "key=0" in case of empty flags > --- > lib/ct-dpif.c | 76 > +++++++++++++++++++++++++++++---------------------------- > lib/ct-dpif.h | 4 +++ > 2 files changed, 43 insertions(+), 37 deletions(-) >
Applied. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
