This series has 2 commits for DSCP and one bug fix not related to it. Not sure why they are on the same series. For DSCP, there is no way from RTE API point of view to rewrite partial bits on the DSCP byte. I think those are NACK. Please explain if I'm wrong. For the bug fix commit, the code is OK but the commit message tells a long story, opinions etc instead of just stating the bug fix.
>-----Original Message----- >From: Simon Horman <[email protected]> >Sent: Wednesday, 26 October 2022 12:05 >To: [email protected] >Cc: Eelco Chaudron <[email protected]>; Ilya Maximets ><[email protected]>; Eli Britstein <[email protected]>; Chaoyong He ><[email protected]>; [email protected] >Subject: Re: [PATCH v3 0/3] add functions about rte_flow to ovs-dpdk > >External email: Use caution opening links or attachments > > >On Fri, Oct 07, 2022 at 12:39:20PM +0200, Simon Horman wrote: >> This patch series add some logics about rte_flow to ovs-dpdk, includes: >> >> * Support offload of set IPv4/IPv6 DSCP action >> * Enhanced the support of tunnel pop action > >Hi all, > >gentle ping for review. > >> >> Changes since v2 >> * Revise commit messages >> * Add the fix tag to patch 3/3 >> * Revise dscp masking to check for correct partial mask >> * Drop geneve vport patch, differed as future work >> >> Changes since v1 >> * Address checkpatch warnings >> * Drop the geneve decap patch, planning to along with the option support in >the future >> >> Chaoyong He (3): >> netdev-offload-dpdk: Support offload of set IPv4 DSCP action >> netdev-offload-dpdk: Support offload of set IPv6 DSCP action >> netdev-offload-dpdk: Enhance the support of tunnel pop action >> >> lib/netdev-offload-dpdk.c | 47 >+++++++++++++++++++++++++++++++++++---- >> 1 file changed, 43 insertions(+), 4 deletions(-) _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
