On Thu, Oct 20, 2022 at 09:52:15AM +0100, Simon Horman wrote:
> On Fri, Oct 14, 2022 at 03:09:56PM +0200, Ilya Maximets wrote:
> > On 10/14/22 13:38, Simon Horman wrote:
> > > From: Tianyu Yuan <[email protected]>
> > >
> > > This reverts commit dd9881ed55e6 ('tc: Fix stats dump when
> > > using same meter table')
> > >
> > > This patch doesn't solve the tc flow stats update issue and
> > > will lead to failure of system-offloads-traffic testsuite, it
> > > only counts packets surviving after the tc filter, rather than
> > > hitting the filter
> > >
> > > A following patch will come up to solve this flow stats update
> > > issue
> > >
> > > Signed-off-by: Tianyu Yuan <[email protected]>
> > > Signed-off-by: Simon Horman <[email protected]>
> > > ---
> > > lib/tc.c | 11 -----------
> > > 1 file changed, 11 deletions(-)
> >
> >
> > Hi. I'm not really sure what is worse - the undercounting or overcounting.
> > If you think that revert is a good temporary solution then it's fine by me:
> >
> > Acked-by: Ilya Maximets <[email protected]>
>
> Thanks. I see that this could go either way. And to be honest I don't feel
> strongly about it. But our position is that the fix wasn't a fix. So it's
> better to revert it. And work on a proper solution.
Sorry for the delay. I've leant towards the revert and and have
applied this patch accordingly.
* 743499607bdd ("Revert "tc: Fix stats dump when using same meter table"")
https://github.com/openvswitch/ovs/commit/743499607bdd
And backported to branch-3.0:
* d2ebceaff97e ("Revert "tc: Fix stats dump when using same meter table"")
https://github.com/openvswitch/ovs/commit/d2ebceaff97e
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
