On Tue, Nov 01, 2022 at 10:05:32AM +0100, Simon Horman wrote:
> On Mon, Oct 31, 2022 at 02:07:46PM +0100, Ilya Maximets wrote:
> > On 10/21/22 11:10, Simon Horman wrote:
> > > From: Baowen Zheng <[email protected]>
> > >
> > > Add tc action flags when adding police action to offload meter table.
> > >
> > > There is a restriction that the flag of skip_sw/skip_hw should be same for
> > > filter rule and the independent created tc actions the rule uses. In this
> > > case, if we configure the tc-policy as skip_hw, filter rule will be
> > > created
> > > with skip_hw flag and the police action according to meter table will have
> > > no action flag, then flower rule will fail to add to tc kernel system.
> > >
> > > To fix this issue, we will add tc action flag when adding police action to
> > > offload a meter table, so it will allow meter table to work in tc software
> > > datapath.
> > >
> > > Fixes: 5c039ddc64ff ("netdev-linux: Add functions to manipulate tc police
> > > action")
> > > Signed-off-by: Baowen Zheng <[email protected]>
> > > Signed-off-by: Simon Horman <[email protected]>
> > > ---
> > > acinclude.m4 | 6 +++---
> > > include/linux/pkt_cls.h | 11 +++++++----
> > > lib/netdev-linux.c | 20 ++++++++++++++------
> > > lib/tc.c | 21 +++++++++++++++++++++
> > > lib/tc.h | 2 ++
> > > 5 files changed, 47 insertions(+), 13 deletions(-)
> > >
> > > v2:
> > > * Address review of v1
> > > - Update patch description: problem depends on setting tc-policy
> > > - Correct typo in comment: "independently"
> > > - Reformat nl_msg_put_tc_action_flag() declaration
> > > - Rename helper as nl_msg_put_act_tc_policy_flag() and correct
> > > line wrapping of declaration.
> >
> > Hi. Thanks for v2!
> >
> > The code looks correct to me, but I didn't test it.
> > With that in mind:
> >
> > Acked-by: Ilya Maximets <[email protected]>
>
> Thanks Ilya,
>
> I will plan to apply this a little later today.
> I expect that it also needs to be backported to branch-3.0,
> and I'll plan to do that too.
Applied:
* ffcb6f115fe5 ("netdev-linux: Allow meter to work in tc software datapath when
tc-policy is specified")
https://github.com/openvswitch/ovs/commit/ffcb6f115fe5
Backport to branch-3.0.
* 4a2fe9f1e3c9 ("netdev-linux: Allow meter to work in tc software datapath when
tc-policy is specified")
https://github.com/openvswitch/ovs/commit/4a2fe9f1e3c9
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
