On 10/14/22 09:29, yangchang wrote: > The log should be printed with the member name, not the active member name, > and the active member does not judge whether it is NULL. If null,ovs will > crash. > following backtrace: > (gdb) bt > 0 bond_check_admissibility (ofproto/bond.c:877) > 1 is_admissible (ofproto/ofproto-dpif-xlate.c:2574) > 2 xlate_normal (ofproto/ofproto-dpif-xlate.c:3027) > 3 xlate_output_action (ofproto/ofproto-dpif-xlate.c:5284) > 4 do_xlate_actions (ofproto/ofproto-dpif-xlate.c:6960) > 5 xlate_actions (ofproto/ofproto-dpif-xlate.c:7924) > 6 upcall_xlate (ofproto/ofproto-dpif-upcall.c:1237) > 7 process_upcall (ofproto/ofproto-dpif-upcall.c:1456) > 8 upcall_cb (ofproto/ofproto-dpif-upcall.c:1358) > 9 dp_netdev_upcall (lib/dpif-netdev.c:7793) > 10 handle_packet_upcall (lib/dpif-netdev.c:8255) > 11 fast_path_processing (lib/dpif-netdev.c:8374) > 12 dp_netdev_input__ (lib/dpif-netdev.c:8463) > 13 dp_netdev_input (lib/dpif-netdev.c:8501) > 14 dp_netdev_process_rxq_port (lib/dpif-netdev.c:5337) > 15 pmd_thread_main (lib/dpif-netdev.c:6944) > 16 ovsthread_wrapper (lib/ovs-thread.c:422) > 17 ?? (/lib64/libpthread.so.0) > 18 clone (/lib64/libc.so.6) > > Signed-off-by: yangchang <[email protected]> > --- > ofproto/bond.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Good catch! I re-named the patch to: bond: Fix crash while logging not yet enabled member. to better describe the specific problem. With that, applied and backported down to 2.13. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
