On 11/2/22 13:54, Roi Dayan wrote:
> Fix reset features if probe for meter support fails.
>
> Fixes: 92d0d515d67b ("dpif-netlink: Probe for broken Linux meter
> implementations.")
> CC: Justin Pettit <[email protected]>
> Signed-off-by: Roi Dayan <[email protected]>
> ---
> lib/dpif-netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index a620a6ec52dd..cf34dd9af514 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -4105,7 +4105,7 @@ dpif_netlink_meter_get_features(const struct dpif
> *dpif_,
> struct ofputil_meter_features *features)
> {
> if (probe_broken_meters(CONST_CAST(struct dpif *, dpif_))) {
> - features = NULL;
> + memset(features, 0, sizeof(*features));
nit: Don't parenthesize the argument of a sizeof.
> return;
> }
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
