I assume someone else will pull this in as part of the patch set, so:

Acked-by: Justin Pettit <[email protected]>

Ilya, let me know if you'd like me to merge it, though.

--Justin


> On Nov 4, 2022, at 6:06 AM, Roi Dayan <[email protected]> wrote:
> 
> The assignment of the features pointer is not doing
> anything and can be removed.
> 
> CC: Justin Pettit <[email protected]>
> Signed-off-by: Roi Dayan <[email protected]>
> ---
> 
> Notes:
>    v3:
>    - fix get meter features commit to just remove redundant null assignment.
> 
>    v2:
>    - move memset from wrapper call
> 
> lib/dpif-netlink.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index a620a6ec52dd..026b0daa8d83 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -4105,7 +4105,6 @@ dpif_netlink_meter_get_features(const struct dpif 
> *dpif_,
>                                 struct ofputil_meter_features *features)
> {
>     if (probe_broken_meters(CONST_CAST(struct dpif *, dpif_))) {
> -        features = NULL;
>         return;
>     }
> 
> -- 
> 2.38.0
> 

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to