With --enable-Werror and --with-dpdk=no:
../lib/dpctl.c: In function 'dpctl_ct_set_limits':
../lib/ct-dpif.c:698:22: error: 'zone' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
698 | zone_limit->zone = zone;
| ^
../lib/dpctl.c:2139:18: note: 'zone' was declared here
2139 | uint16_t zone;
| ^
../lib/ct-dpif.c:699:23: error: 'limit' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
699 | zone_limit->limit = limit;
| ^
../lib/dpctl.c:2140:18: note: 'limit' was declared here
2140 | uint32_t limit;
| ^
Fixes: 4eeec031d4c4 ("dpctl: Implement dpctl commands for conntrack per zone
limit")
Signed-off-by: Eli Britstein <[email protected]>
---
lib/dpctl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 29041fa3e..714bf3c4b 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -2136,8 +2136,9 @@ dpctl_ct_set_limits(int argc, const char *argv[],
/* Parse ct zone limit tuples */
while (i < argc) {
- uint16_t zone;
- uint32_t limit;
+ uint32_t limit = 0;
+ uint16_t zone = 0;
+
if (!ct_dpif_parse_zone_limit_tuple(argv[i++], &zone, &limit, &ds)) {
error = EINVAL;
goto error;
--
2.26.2.1730.g385c171
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
