On Mon, Nov 28, 2022 at 02:17:40PM +0100, Eelco Chaudron wrote: > > > On 28 Nov 2022, at 14:11, Marcelo Leitner wrote: > > > On Mon, Nov 28, 2022 at 07:11:05AM +0000, Tianyu Yuan wrote: ... > >> > >> Furthermore, I think the current stats for each action mentioned in 2) > >> cannot represent the real > >> hw stats and this is why [ RFC net-next v2 0/2] (net: flow_offload: add > >> support for per action > >> hw stats) will come up. > > > > Exactly. Then, when this patchset (or similar) come up, it won't > > update all actions with the same stats anymore. It will require a set > > of stats from hw for the gact with PIPE action here. But if drivers > > are ignoring this action, they can't have specific stats for it. Or am > > I missing something? > > > > So it is better for the drivers to reject the whole flow instead of > > simply ignoring it, and let vswitchd probe if it should or should not > > use this action. > > Please note that OVS does not probe features per interface, but does it per > datapath. So if it’s supported in pipe in tc software, we will use it. If the > driver rejects it, we will probably end up with the tc software rule only.
Ah right. I remember it will pick 1 interface for testing and use those results everywhere, which then I don't know if it may or may not be a representor port or not. Anyhow, then it should use skip_sw, to try to probe for the offloading part. Otherwise I'm afraid tc sw will always accept this flow and trick the probing, yes. Marcelo _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
