Ilya Maximets <[email protected]> writes: > check_attr_len() currently reports all unknown keys as keys with bad > length. For example, IPv6 extension headers are printed out like this > in flow dumps: > > eth_type(0x86dd),ipv6(...) > (bad key length 2, expected -1)(00 00/(bad mask length 2, expected -1)(00 > 00), > icmpv6(type=0/0,code=0/0) > > However, since the key is unknown, the length check on it makes no > sense and should be ignored. This will allow the unknown key to be > caught later by the format_unknown_key() function and printed in a > more user-friendly way: > > eth_type(0x86dd),ipv6(...),key32(00 00/00 00),icmpv6(type=0/0,code=0/0) > > '32' here is the actual index of the key attribute, so we know > that it is unknown attribute #32 with the value/mask pair printed > out inside the parenthesis. > > Signed-off-by: Ilya Maximets <[email protected]> > ---
LGTM. Acked-by: Aaron Conole <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
