On Tue, Nov 29, 2022 at 5:16 AM Dumitru Ceara <[email protected]> wrote:
>
> On 11/29/22 09:14, Han Zhou wrote:
>
> >
> > Better to add a brief help message for the .sh itself. Otherwise, it
> > invokes the .py and outputs the help message of the .py, which is a
little
> > misleading (although it is fairly easy to figure out by just looking
into
> > the .sh script :) )
> >
> > Acked-by: Han Zhou <[email protected]>
> >
>
> What do you think of the following incremental? I can fold it in if it
> looks good to you.
Looks good to me. Thanks!
Han
>
> Thanks for the review!
>
> Regards,
> Dumitru
>
> ---
> diff --git a/tutorial/ovn-lb-benchmark.sh b/tutorial/ovn-lb-benchmark.sh
> index 5c30adf38a..8627176e56 100755
> --- a/tutorial/ovn-lb-benchmark.sh
> +++ b/tutorial/ovn-lb-benchmark.sh
> @@ -1,5 +1,12 @@
> #!/bin/bash
>
> +usage() {
> + echo "Usage: $1 <n_routers> <n_lbs> <n_backends_per_lb>
<use_template>"
> + exit 0
> +}
> +
> +([ "${1:-"--usage"}" = "--usage" ] || [ "$#" -ne "4" ]) && usage $0
> +
> nrtr=$1
> nlb=$2
> nbackends=$3
> ---
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
