On 11/29/22 15:37, Mike Pattrick wrote: > On Tue, Oct 25, 2022 at 12:38 PM Ilya Maximets <[email protected]> wrote: >> >> 100 Mbps was a fair assumption 13 years ago. Modern days 10 Gbps seems >> like a good value in case no information is available otherwise. >> >> The change mainly affects QoS which is currently limited to 100 Mbps if >> the user didn't specify 'max-rate' and the card doesn't report the >> speed or OVS doesn't have a predefined enumeration for the speed >> reported by the NIC. >> >> Calculation of the path cost for STP/RSTP is also affected if OVS is >> unable to determine the link speed. >> >> Lower link speed adapters are typically good at reporting their speed, >> so chances for overshoot should be low. But newer high-speed adapters, >> for which there is no speed enumeration or if there are some other >> issues, will not suffer that much. >> >> Signed-off-by: Ilya Maximets <[email protected]> > > I think this is a reasonable change, 100MB has mostly been relegated > to embedded devices for a long time. > > Acked-by: Mike Pattrick <[email protected]>
Applied. Thanks! > > Slightly related, I noticed that we're missing support for 20 and > 56Gbps, we should probably add those as well. I've never see 56Gbps Ethernet NIC in practice, they tend to all be Infiniband ones, but maybe I'm just wrong. In any case, maybe you, Adrian, can fix that as well while working on support for 25/50/etc link speeds detection? Should be simple enough. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
