On 12/2/22 18:31, Vladislav Odintsov wrote: > This patch is intended to show that currently it's possible to build > ECMP group of 65k buckets. > > Signed-off-by: Vladislav Odintsov <[email protected]> > --- > northd/northd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/northd/northd.c b/northd/northd.c > index e1f3bace8..f8f7977ae 100644 > --- a/northd/northd.c > +++ b/northd/northd.c > @@ -9271,7 +9271,7 @@ static void > ecmp_groups_add_route(struct ecmp_groups_node *group, > const struct parsed_route *route) > { > - if (group->route_count == UINT16_MAX) { > + if (group->route_count == 1024) { > static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1); > VLOG_WARN_RL(&rl, "too many routes in a single ecmp group."); > return;
Should we make the limit configurable? What if the CMS wants to install a route with more than 1K paths? Not sure if that's realistic but I would avoid the hardcoded 1K. Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
