On 12/5/22 18:00, Numan Siddique wrote:
> On Mon, Dec 5, 2022 at 11:37 AM Dumitru Ceara <[email protected]> wrote:
>>
>> On 12/2/22 18:31, Vladislav Odintsov wrote:
>>> This change will be useful in next commit.
>>>
>>> Signed-off-by: Vladislav Odintsov <[email protected]>
>>> ---
>>
>> Hi Vladislav,
>>
>> This looks OK to me but I think I'd squash it in the patch that actually
>> uses the new way of calling ic_route_find().
> 
> +1 for this.
> 
> I'd also suggest splitting this series into 2.
> 
> Patch 1, 2, 3, 5 and 7 into 1 series since these patches are fixing ic
> related issues.
> These can be backported easily to older branches.
> 
> Patch 4 and 6 can be a separate patch series independent of these.   I
> think these 2 patches
> need to be carefully reviewed.
> 
> @Dumitru Ceara  Do you have any objections ?

No objections, sounds good to me.

> 
> Thanks for identifying these issues and fixing them.
> 

+1, thanks Vladislav and Anton!

> Thanks
> Numan
> 

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to