On 12/5/22 07:23, Han Zhou wrote: > > > On Fri, Nov 25, 2022 at 4:36 AM Ilya Maximets <[email protected] > <mailto:[email protected]>> wrote: >> >> OVSDB creates a separate object for each weak reference in order to >> track them and there could be a significant amount of these objects >> in the database. >> >> We also had problems with number of these objects growing out of >> bounds recently. So, adding them to a memory report seems to be >> a good thing. >> >> Counting them globally to cover all the copied instances in transactions >> and the transaction history (even though there should be none). >> It's also hard to count them per-database, because weak references >> are stored on destination rows and can be destroyed either while >> destroying the destination row or while removing the reference from >> the source row. Also, not all the involved functions have direct >> access to the database object. So, there is no single clear place >> where counters should be updated. >> >> Signed-off-by: Ilya Maximets <[email protected] <mailto:[email protected]>> >> --- >> ovsdb/ovsdb.c | 4 ++++ >> ovsdb/ovsdb.h | 4 ++++ >> ovsdb/row.c | 5 ++++- >> ovsdb/transaction.c | 2 ++ >> 4 files changed, 14 insertions(+), 1 deletion(-) >> > Acked-by: Han Zhou <[email protected] <mailto:[email protected]>>
Applied. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
