On Tue, Dec 13, 2022 at 2:33 PM Abhiram R N <[email protected]> wrote: > > This patch set adds a new feature in OVN. > i.e Remote Port Mirroring > Already in OVS this support is present. We are leveraging that > and trying to add support in OVN. > So that from OVN APIs we can create/delete mirrors and > attach and detaches sources to them. > > Mirror creation just creates the mirror. The lsp-attach-mirror > triggers the sequence to create Mirror in OVS DB on compute node. > > Note: This is targeted to mirror to destinations anywhere outside the > cluster where the analyser resides and it need not be an OVN node. > > For mirror filter currently we have decided to support 'to-lport' and > 'from-lport' since we are observing issue for the 'both' case. > It will pursued with OVS team separately and tracked via a BZ and > after getting that fixed we can enchance the filter to support > 'both' as well. > > Abhiram R N (3): > OVN Remote Port Mirroring: Add new Schemas in NB > OVN Remote Port Mirroring: northd changes to sync NB and SB > OVN Remote Port Mirroring: controller changes to create ovs mirrors
Thanks Abhiram for adding this feature and for the patience. And thanks Ihar and Mark for the reviews. I applied this patch series to the main branch and also backported to branch-22.12 with some changes in patch 1 and patch 3. I will reply to the individual patches about the changes. The biggest change I made was marking this feature as experimental. Hopefully we can remove the experimental tag in the next release when it undergoes a good amount of testing. It would be great if you can work on adding some multinode system tests. The multinode system test patches are up for review - https://patchwork.ozlabs.org/project/ovn/list/?series=330884 Numan > > NEWS | 1 + > controller/automake.mk | 4 +- > controller/mirror.c | 418 +++++++++++++++++++++++++++++ > controller/mirror.h | 33 +++ > controller/ovn-controller.c | 9 + > northd/en-northd.c | 4 + > northd/inc-proc-northd.c | 4 + > northd/northd.c | 133 ++++++++++ > northd/northd.h | 2 + > ovn-nb.ovsschema | 25 +- > ovn-nb.xml | 55 ++++ > ovn-sb.ovsschema | 26 +- > ovn-sb.xml | 50 ++++ > tests/ovn-nbctl.at | 102 +++++++ > tests/ovn-northd.at | 105 ++++++++ > tests/ovn.at | 514 ++++++++++++++++++++++++++++++++++++ > utilities/ovn-nbctl.8.xml | 51 ++++ > utilities/ovn-nbctl.c | 334 +++++++++++++++++++++++ > utilities/ovn-sbctl.c | 4 + > 19 files changed, 1869 insertions(+), 5 deletions(-) > create mode 100644 controller/mirror.c > create mode 100644 controller/mirror.h > > -- > 2.31.1 > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
