Thanks Dumitru! Regards, Vladislav Odintsov
> On 16 Dec 2022, at 15:17, Dumitru Ceara <dce...@redhat.com> wrote: > > Hi Vladislav, > > I pushed the series to main branch and branch-22.12. I also backported > the first 4 patches all the way down to branch-22.03. > > Thanks a lot for the fixes (and thanks Numan for the review)! > > Regards, > Dumitru > > On 12/16/22 10:58, Vladislav Odintsov wrote: >> Hi Dumitru, >> >> Regards, >> Vladislav Odintsov >> >>> On 16 Dec 2022, at 02:16, Dumitru Ceara <dce...@redhat.com> wrote: >>> >>> On 12/15/22 22:30, Vladislav Odintsov wrote: >>>> Thanks Numan for the review. >>>> >>>> It seems that for some reason appeared a memory leak, which constantly >>>> reproduces. >>> >>> Do you mean this one? >>> >>> Direct leak of 64 byte(s) in 1 object(s) allocated from: >>> #0 0x49a052 in calloc >>> (/home/runner/work/ovn/ovn/ovn-22.12.90/_build/sub/ic/ovn-ic+0x49a052) >>> #1 0x751142 in xcalloc__ /home/runner/work/ovn/ovn/ovs/lib/util.c:121:31 >>> #2 0x751170 in xzalloc__ /home/runner/work/ovn/ovn/ovs/lib/util.c:131:12 >>> #3 0x751235 in xzalloc /home/runner/work/ovn/ovn/ovs/lib/util.c:165:12 >>> #4 0x740353 in ovsdb_idl_txn_add_map_op >>> /home/runner/work/ovn/ovn/ovs/lib/ovsdb-idl.c:4160:29 >>> #5 0x7402bf in ovsdb_idl_txn_write_partial_map >>> /home/runner/work/ovn/ovn/ovs/lib/ovsdb-idl.c:4317:5 >>> #6 0x71c57f in icsbrec_port_binding_update_external_ids_setkey >>> /home/runner/work/ovn/ovn/ovn-22.12.90/_build/sub/lib/ovn-ic-sb-idl.c:7220:5 >>> #7 0x4d3696 in update_isb_pb_external_ids >>> /home/runner/work/ovn/ovn/ovn-22.12.90/_build/sub/../../ic/ovn-ic.c:573:5 >>> #8 0x4d2017 in create_isb_pb >>> /home/runner/work/ovn/ovn/ovn-22.12.90/_build/sub/../../ic/ovn-ic.c:713:5 >>> #9 0x4ce6af in port_binding_run >>> /home/runner/work/ovn/ovn/ovn-22.12.90/_build/sub/../../ic/ovn-ic.c:800:21 >>> #10 0x4cbb87 in ovn_db_run >>> /home/runner/work/ovn/ovn/ovn-22.12.90/_build/sub/../../ic/ovn-ic.c:1737:5 >>> #11 0x4cac7a in main >>> /home/runner/work/ovn/ovn/ovn-22.12.90/_build/sub/../../ic/ovn-ic.c:2026:17 >>> #12 0x7fcd3d9e7082 in __libc_start_main >>> (/lib/x86_64-linux-gnu/libc.so.6+0x24082) >>> >>> From: https://github.com/ovsrobot/ovn/actions/runs/3706396547 >>> >>> If so, I've seen it a few times before in CI and didn't have >>> time to investigate closely. I'm quite confident it's not >>> related to your changes so I think it's fine to push your >>> series. Like that it would also make it in time for the >>> 22.12.0 release. >> >> Yes, I was talking about this trace. So, I walked through it and see that >> it’s really not connected with my patchset, and it can be applied. >> >>> >>>> I’ll give it a time tomorrow to find the source of a problem. >>> >>> I'll wait at least until Friday morning (CET). >> >> Anyway if I succeed to fix this issue, I’ll send a separate patch for that. >> >>> >>>> >>>> Regards, >>>> Vladislav Odintsov >>> >>> Regards, >>> Dumitru >>> >>>> >>>>> On 16 Dec 2022, at 00:21, Numan Siddique <num...@ovn.org> wrote: >>>>> >>>>> On Thu, Dec 15, 2022 at 12:02 PM Vladislav Odintsov <odiv...@gmail.com >>>>> <mailto:odiv...@gmail.com>> wrote: >>>>>> >>>>>> v2 -> v3: >>>>>> - Split patch #3 by two: first fixes a bug with duplicated route >>>>>> advertisement and will be considered for back-porting; the second one >>>>>> changes ovn-ic SB:Route schema and documents ovn-ic upgrade details. >>>>>> - Address Dumitru's comment regarding loggin rate-limit. >>>>>> >>>>>> v1 -> v2: >>>>>> - Split series by two: OVN IC-related changes and northd OF bucket limits >>>>>> - Squash two patches in one >>>>>> - Fix memory leak in add_to_routes_ad() >>>>>> - Addressed review comments by Dumitru >>>>>> >>>>>> v1 description here: >>>>>> https://patchwork.ozlabs.org/project/ovn/cover/20221202173147.3032702-1-odiv...@gmail.com/ >>>>>> >>>>>> Vladislav Odintsov (5): >>>>>> ic: remove orphan ovn interconnection routes >>>>>> ic: lookup southbound port_binding only if needed >>>>>> ic: prevent advertising/learning multiple same routes >>>>>> ic: minor code improvements >>>>>> ic-sb schema: add index for routes table & document upgrade path >>>>> >>>>> For the entire series: >>>>> >>>>> Acked-by: Numan Siddique <num...@ovn.org <mailto:num...@ovn.org>> >>>>> >>>>> Numan >>>>> >>>>>> >>>>>> Documentation/intro/install/ovn-upgrades.rst | 20 +++ >>>>>> NEWS | 4 + >>>>>> ic/ovn-ic.c | 142 +++++++++++++------ >>>>>> ovn-ic-sb.ovsschema | 6 +- >>>>>> tests/ovn-ic.at <http://ovn-ic.at/> | 133 >>>>>> +++++++++++++++++ >>>>>> 5 files changed, 257 insertions(+), 48 deletions(-) >>>>>> >>>>>> -- >>>>>> 2.36.1 >>>>>> >>> >>> _______________________________________________ >>> dev mailing list >>> d...@openvswitch.org >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
