On 12/20/22 15:26, Eelco Chaudron wrote: > > > On 20 Dec 2022, at 14:39, Ilya Maximets wrote: > >> On 12/20/22 14:34, Eelco Chaudron wrote: >>> >>> >>> On 19 Dec 2022, at 13:20, Ilya Maximets wrote: >>> >>>> All supported versions of Fedora do package libxdp and libbpf, so it >>>> makes sense to enable AF_XDP support. >>>> >>>> Control files for debian packaging are much less flexible, so its hard >>>> to enable AF_XDP builds while not breaking builds for version of Ubuntu >>>> and Debian that do not package libbpf or libxdp. >>>> >>>> Signed-off-by: Ilya Maximets <[email protected]> >>> >>> Well not sure if this is true, as on my Fedora35 it seems to be broken :( >>> >>> I quickly tried it on a vagrant fedora35 instance, and the same problem. >>> It has the following (might be xdptools issue, but Toke is out). >>> >>> [vagrant@f35 ~]$ rpm -qa | grep -E "xdp|bpf" >>> libbpf-0.6.1-2.fc35.x86_64 >>> libbpf-devel-0.6.1-2.fc35.x86_64 >>> bpftool-5.19.4-100.fc35.x86_64 >>> libxdp-1.2.0-2.fc35.x86_64 >>> xdp-tools-1.2.0-2.fc35.x86_64 >> >> I guess, you might have the issue similar to what Frode had, >> because you have an old libbpf with a new libxdp. And they >> are likely incompatible. >> >> FWIW, f35 is EOL, so nobody should use it. :) > > This might be a distro package issue :( Including Toke, who might know more? > > This is the link/load error: > > ovsdb-tool: symbol lookup error: /lib64/libxdp.so.1: undefined symbol: > silence_libbpf_logging
I looked at the sources and silence_libbpf_logging() is a function in xdp-tools source tree. That is weird, it might be the problem with the build process for that package itself. One potential workaround is to not link with libxdp if we detect libbpf older than 0.7. Old libbpf should have all the functionality we actually need. I can try to implement that. > >>> >>> //Eelco >>> >>>> --- >>>> rhel/openvswitch-fedora.spec.in | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/rhel/openvswitch-fedora.spec.in >>>> b/rhel/openvswitch-fedora.spec.in >>>> index fbfcdcf63..7676eb737 100644 >>>> --- a/rhel/openvswitch-fedora.spec.in >>>> +++ b/rhel/openvswitch-fedora.spec.in >>>> @@ -26,8 +26,8 @@ >>>> %bcond_without libcapng >>>> # To enable DPDK support, specify '--with dpdk' when building >>>> %bcond_with dpdk >>>> -# To enable AF_XDP support, specify '--with afxdp' when building >>>> -%bcond_with afxdp >>>> +# To disable AF_XDP support, specify '--without afxdp' when building >>>> +%bcond_without afxdp >>>> >>>> # If there is a need to automatically enable the package after >>>> installation, >>>> # specify the "--with autoenable" >>>> -- >>>> 2.38.1 >>> > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
