On 12/15/22 17:42, Dan Williams wrote:
> Make it clear which of the DB args is the clusterd one.
> 
> Signed-off-by: Dan Williams <[email protected]>
> ---
>  ovsdb/ovsdb-tool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c
> index 60f353197bfd7..33719d38a4d09 100644
> --- a/ovsdb/ovsdb-tool.c
> +++ b/ovsdb/ovsdb-tool.c
> @@ -187,7 +187,7 @@ usage(void)
>             "  compare-versions A OP B  compare OVSDB schema version 
> numbers\n"
>             "  query [DB] TRNS         execute read-only transaction on DB\n"
>             "  transact [DB] TRNS      execute read/write transaction on DB\n"
> -           "  cluster-to-standalone DB DB    Convert clustered DB to\n"
> +           "  cluster-to-standalone DB clustered-DB  Convert clustered DB 
> to\n"
>             "      standalone DB when cluster is down and cannot be\n"
>             "        revived\n"
>             "  [-m]... show-log [DB]   print DB's log entries\n"

Hi, Dan.  Thanks for the patch!  It makes sense to me as it is
indeed unclear which DB is which.

The patch looks good, but maybe we can re-format the message
a bit to match the style of surrounding options?  Something
like this:

  cluster-to-standalone DB CLUSTERED-DB
    convert CLUSTERED-DB to standalone DB when cluster is down
    and cannot be revived

What do you think?

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to