On 12/22/22 16:21, Eelco Chaudron wrote: > > > On 22 Dec 2022, at 16:09, Eelco Chaudron wrote: > >> On 22 Dec 2022, at 16:04, Eelco Chaudron wrote: >> >>> On 22 Dec 2022, at 1:06, Ilya Maximets wrote: >>> >>>> With this change we will try to detect all the netdev-afxdp >>>> dependencies and enable AF_XDP support by default if they are >>>> present at the build time. >>>> >>>> Configuration script behaves in a following way: >>>> >>>> - ./configure --enable-afxdp >>>> >>>> Will check for AF_XDP dependencies and fail if they are >>>> not available. >>>> >>>> - ./configure --disable-afxdp >>>> >>>> Disables checking for AF_XDP. Build will not support >>>> AF_XDP even if all dependencies are installed. >>>> >>>> - Just ./configure or ./configure --enable-afxdp=auto >>>> >>>> Will check for AF_XDP dependencies. Will print a warning >>>> if they are not available, but will continue without AF_XDP >>>> support. If dependencies are available in a system, this >>>> option is equal to --enable-afxdp. >>>> >>>> '--disable-afxdp' added to the debian and fedora package builds >>>> to keep predictable behavior. >>>> >>>> Signed-off-by: Ilya Maximets <[email protected]> >>>> --- >>> >>> Looks like the auto-enable is not working on my fedora35 machine (with or >>> without libxdp installed) :) >>> >>> [ebuild:~/...eview/ovs_ilya_afxdp]$ ./configure --enable-Werror >>> --sysconfdir=/etc --enable-afxdp | grep -i -E "af_xdp|afxdp" >>> checking whether AF_XDP is enabled... yes >>> [ebuild:~/...eview/ovs_ilya_afxdp]$ ./configure --enable-Werror >>> --sysconfdir=/etc --disable-afxdp | grep -i -E "af_xdp|afxdp" >>> checking whether AF_XDP is enabled... no >>> [ebuild:~/...eview/ovs_ilya_afxdp]$ ./configure --enable-Werror >>> --sysconfdir=/etc --enable-afxdp=auto | grep -i -E "af_xdp|afxdp" >>> checking whether AF_XDP is enabled... no >>> [ebuild:~/...eview/ovs_ilya_afxdp]$ ./configure --enable-Werror >>> --sysconfdir=/etc | grep -i -E "af_xdp|afxdp" >>> checking whether AF_XDP is enabled... no >> >> So we need libxdp-devel to be installed even with libbpf 0.6. Though you >> changes it it would not need it for < 0.7? >> > > Ignore all of this :) I was on the v2 branch when testing this patch :( > > Acked-by: Eelco Chaudron <[email protected]> >
Thanks! I applied the set now. The first CI fix additionally backported down to 2.13. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
